Githawk: Unable to turn on notifications

[timonus]

In the latest beta the notifications rows just say “Settings”, but when I tap through Settings.app doesn’t show notifications permissions for GitHawk. The app needs to request permission at some point via this method.

_{Sent with GitHawk}

[rnystrom]

Oh no, thanks for this! Def need to fix

_{Sent with GitHawk}

[gingerbeardman]

I have managed to turn them on, but I'm yet to receive a notification.

Am I missing something?

[Huddie]

I think I also was supposed to receive and didn’t.

_{Sent with GitHawk}

[drewvolz]

The app does contain the call to prompt for notification permissions via requestAuthorization, but the conditions that trigger it to prompt might need tweaking.

https://github.com/GitHawkApp/GitHawk/blob/05fe58394c5067340ebb29eea1fca484f593feed/Classes/Systems/BadgeNotifications.swift#L59-L72

@rnystrom on a clean install of the application:

• isBadgeEnabled and isLocalNotificationEnabled are both false, so...
• options.isEmpty is true.

So both .badge and .alert are not being inserted into options.

The app currently _does_ have notifications enabled for me via TestFlight, ~but I've yet to see a local notification be generated. Prompting and generating/receiving could be separate issues here.~

edit: I do see notifications being generated -- the last part of my comment is now outdated.

[gingerbeardman]

I've started to see notifications in 1.23 without doing anything different

[gingerbeardman]

tapping one notification clears all other notifications from the lock screen?

When viewing an issue, tapping a notification foes not take you to the new issue?