Githawk: Filter Fabric Setup by Bundle Identifier

Created on 24 Sep 2018  路  4Comments  路  Source: GitHawkApp/GitHawk

Probably way too late to suggest this but maybe we should wrap the Fabric initialise method in a check that the bundle identifier matches Ryan's production one?

Prevent the ever growing list of slightly alternative bundle identifiers where people have cloned the repo and had to change to provision their own device (looks pretty intense in Fabric now 馃槀)

Super minor change, not sure if volumes of value now, will leave it open to someone else to make a decision on

if Bundle.main.bundleIdentifier == "com.whoisryannystrom.freetime" {
    // Fabric Init
}

Most helpful comment

It鈥檚 why I unsubscribed from those emails 馃槄

Sent with GitHawk

All 4 comments

To make a note, Fabric is deprecated and Google is asking all of its user to migrate to Firebase. We do have plenty of time to decide (till mid of 2019)

Suspect the same message would be made true irrespective of which tool which we decide to use, good to not setup unnecessarily

We've also had Firebase once in the project, wouldn't be totally against moving to it once it has all the Fabric functionality transferred over

Lol I was wondering where those were coming from. Too funny.

But ya we鈥檙e gonna need to replace Fabric in the long run...

Sent with GitHawk

It鈥檚 why I unsubscribed from those emails 馃槄

Sent with GitHawk

Was this page helpful?
0 / 5 - 0 ratings

Related issues

weyert picture weyert  路  3Comments

BasThomas picture BasThomas  路  3Comments

rizwankce picture rizwankce  路  3Comments

BasThomas picture BasThomas  路  3Comments

rnystrom picture rnystrom  路  3Comments