Githawk: Missing Subscribe/Unsubscribe

[muuvmuuv]

I‘m missing a button to subscribe and unsubscribe a issue or pr. So this is a feature request :)

Bug Report Dump (Auto-generated)

Version 1.22.0 (1534395229)
Device: iPhone 6s (iOS 11.4.1)
TestFlight: false

[BasThomas]

You can subscribe/unsubscribe to an issue or pull request in your inbox. These should have this “loudspeaker” icon.

Where else would you expect to see this? Would you like to be able to subscribe to an issue you’re not subscribed to in the first place?

_{Sent with GitHawk}

[muuvmuuv]

Yes, exactly. The loudspeaker icon is new, isn't it? Will it subscribe only for app notification or for GitHub, so that I can view notification is the browser too?

[Huddie]

The loudspeaker 📢 is an interesting “shortcut”
You can only see it in your inbox so it means your already subscribed to it.
If you unsubscribe it gives you the chance to subscribe assuming you don’t mark it read, meaning you don’t read the issue.
I feel more likely you read the issue and then want to unsubscribe which means you must go to view all and then unsubscribe? It just feels a bit weird.

I’d suggest removing the loudspeaker 📢 from inbox and moving it into the manager button below the divider along with #2140.
This would allow for subscribing/unsubscribing to any issue you want.

I think then inbox cells can be simplified to just the read button and a more button see #2127 for an example.

_{Sent with GitHawk}

[muuvmuuv]

I think so too, simplifiy them would also make more space for other issues, everything else should be setup in the issue itself.

For me the loudspeaker would have the same functionality as the subscribe button in GitHub and I can view subscribed items somewhere. The burger menu in the bottom right would be a nice place as it correlates to the issue outside GitHawk. Maybe a swipe gesture with „Swipe to unread“ would some it the whatsapp way? More people would be familiar with that.

Anyway awesome work! New design is great!

_{Sent with GitHawk}

[rnystrom]

Sub/un in the burger menu would be great! Also removes the need to hide/show the menu button which would clean up a lot of code!

_{Sent with GitHawk}

[ijm8710]

Would love this as well

Extra benefit is it would show intra-post if you’re subscribed or not

[ijm8710]

Hey @Huddie politely visiting since it seems you’re actively working on #2482 and they’re semi-related; if the logic is fresh enough for you to potentially have interest in jumping on this at same time. Purely just to throw it out there, no worries if you pass :)

[Huddie]

@ijm8710 I actually meant to tag this issue in my PR, the PR you tagged is to add this support.

[ijm8710]

Sweet, would it make sense to have a section notation as well where it says you’re actively watching/subscribed to said thread like it does on github. Somewhat similar to how you guys created the referenced subsections

[Huddie]

Not sure I follow.
In the manger content menu it says either : subscribe, unsubscribe so you’ll know your current status

_{Sent with GitHawk}

[ijm8710]

Meant this

While what you said is absolutely true, I just meant having the blurb so you know without actioning the manager button

Essentially GitHub offers the subscribe unsubscribe which you’ve included in the manager button but they also have the blurb as welll explaining it (with the signal symbol) which I was curious if you saw value to having at bottom of thread

[Huddie]

@ijm8710 maybe for a separate PR, focusing on this one first. Good suggestion just wanna do one thing at a time

_{Sent with GitHawk}

[goerz]

Strongly seconded. I very frequently subscribe to issues on repos where I'm "just a user/beta tester", so that I get notified when a fix for a particular problem is available. This very issue would a prime example! (of course, now I've commented on it, which subscribes me to updates, but in most cases, I'm just lurking without a comment).