Githawk: Move the “lock” button to below the divider line

Created on 23 Aug 2018  Â·  8Comments  Â·  Source: GitHawkApp/GitHawk

Is your feature request related to a problem? Please describe.
When clicking on the hamburger button to modify the issue, the buttons are grouped into two groups: the close option and everything else:

Describe the solution you'd like
I suggest this divider be moved up one spot, above the lock button. This would divide the options into ones that prompt for more information (above the line) and ones that take action immediately (lock/close).

Describe alternatives you've considered
We could leave it as-is, but there’s currently no indication that locking the issue will lock it right away instead of prompting for confirmation, like all similarly-styled options do.

✨ good first issue 🎨 design

Most helpful comment

FYI @Huddie if you put “Fixes #XXX” (where XXX is an issue number) in the initial comment of a PR, the issue will be closed when the PR gets merged.

All 8 comments

I agree
Maybe a color change
Sent with GitHawk

I’m down with this. Lift gray would be good for the icon. Easy issue for someone to pick up.

Sent with GitHawk

This issue should be able to be closed

FYI @Huddie if you put “Fixes #XXX” (where XXX is an issue number) in the initial comment of a PR, the issue will be closed when the PR gets merged.

@j-f1 really?! Even if I don’t normally have the ability to close the issue? That’s cool. Thank you

Sent with GitHawk

I think the requirement is that either you or the person merging the PR has the ability to close the issue (although I’m not sure about the former).

@j-f1 Well, thanks for the tip. I never knew that.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

BasThomas picture BasThomas  Â·  3Comments

weyert picture weyert  Â·  3Comments

rnystrom picture rnystrom  Â·  3Comments

viktorgardart picture viktorgardart  Â·  3Comments

BasThomas picture BasThomas  Â·  3Comments