Githawk: Expand cell button no working on table cells

[Huddie]

I can’t seem to click the expand comment cell (blue button with 3 dots)

Bug Report Dump (Auto-generated)

Version 1.22.0 (1534118943)
Device: iPhone 6s (iOS 11.4.1)
TestFlight: true

[Huddie]

Is this just me?

_{Sent with GitHawk}

[rnystrom]

Hmm nope doesn't work for me either, I'll try to fix really quick

[rnystrom]

So this is b/c of the nested UIScrollView underneath. Classic problem where it eats the touches and disables cell selection.

Going to low-pri this for now.

[ghost]

I can't reproduce this in commit 966cb1a4d1238bc2e92a42afbaacd3b6ba497d6e dated 27 Sep 2018 on master

Xcode Version 10.0 (10A254a)
Simulator iPhone XR iOS 12

[rnystrom]

It’s def a bug that was happening, but I haven’t tried iOS 12. Maybe it’ll sort itself out?

_{Sent with GitHawk}

[ghost]

Like a fine wine 🍷

[Huddie]

@rnystrom Haven’t seen this is a bit. Chalk it up to iOS 12 and close?

_{Sent with GitHawk}

[rnystrom]

Nah it’s still an issue

_{Sent with GitHawk}

[Huddie]

Haha is it a hard fix? If you have an idea what’s necessary I can take a look

_{Sent with GitHawk}

[rnystrom]

@Huddie see comment above: tables have a UICollectionView (scroll view) in them which eats the touch event required to call UICollectionViewDelegate.didSelectCellAtIndexPath(:).

Some options:

• Add a UITapGestureRecognizer to the table cell, create a IssueCommentTableCellDelegate, and forward the event
• Go deep and on UITouch and UIScrollView and UICollectionView to find a fix
  
  
  
  • There may be some combo of touchesBegan(:) and its sibling methods to make it work
  
  
  • Or maybe there's an override to gestureShouldBegin() or w/e the method is to make it work
  
  
• Update IssueCommentBaseCell and its delegate so it has a single tap (already has double tap). Extend the delegate w/ a new tap method
  
  
  
  • Remove cell expansion from cell selection
  
  
  • This is probably the best option!
  
  

Would be a huge help!

[Huddie]

@rnystrom I’ll play around 👾

_{Sent with GitHawk}