Githawk: Processing webview links that we can

Created on 10 Aug 2018  路  10Comments  路  Source: GitHawkApp/GitHawk

Once #317 is complete this will not be so relevant but currently if I tap on a users avatar I get redirected to their profile page. From there I can click a repo that they work on and the new web page will load for that repo.

Suggestion: Since we have a section in the app that can process repo info why don't we eject them from the WebView version and just render up the GitHawk repo screen?

Process: I believe it would require us to switch from SFSafariViewController to WKWebView and monitor the Url. If the Url is one that represents a repo, pop the webview, open the repo page in app.

Most helpful comment

But I agree, the current situation isn't great either. Time to work on #317 :)

All 10 comments

Not a big fan of moving away from the SafariVC though.

For security ?

Edit: Just feels weird that we鈥檙e in the webview when we can be in app

Sent with GitHawk

Security / logging into GitHub on web, and usability.

But I agree, the current situation isn't great either. Time to work on #317 :)

Security / logging into GitHub on web, and usability.

@BasThomas security was also a though I had. Usability though I feel like is better in app and could be made better.

In terms of #317 - This is exciting. Not sure what I鈥檇 be able to help with but deff think this is gonna be great for the app!

Sent with GitHawk

Would we need a new branch or something to hack on #317? I've got some code to dump, a bunch of boilerplate GraphQL (mentioned in #1894) that could get that project started.

Go for it!

Sent with GitHawk

@BasThomas or anyone else - I just pushed a branch called UserProfile.. can you all see and edit it? Is this the correct way to approach it from a project management standpoint?

@BrianLitwin I'd recommend just making a WIP PR that everyone can see and comment on

Closing because its a dup of #441

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rnystrom picture rnystrom  路  3Comments

viktorgardart picture viktorgardart  路  3Comments

BasThomas picture BasThomas  路  3Comments

rnystrom picture rnystrom  路  3Comments

rnystrom picture rnystrom  路  3Comments