Githawk: Readme needs insets restored

Created on 28 Jul 2018  路  3Comments  路  Source: GitHawkApp/GitHawk

馃悰 bug 馃帹 design
Source
picture rnystrom

Most helpful comment

@rnystrom Just released AutoInsetter 1.2.5 which has the fix included.

Current versions of Tabman are constrained to AutoInsetter 1.2.x releases so a simple pod update should be all you need. 馃槃

Thanks for the patch! 馃帀

cc @BasThomas

picture msaps on 30 Jul 2018
❤1 🎉1

All 3 comments

Bummer, bug is here as a dependency to TabMan:

https://github.com/uias/AutoInsetter/blob/9d74f6971bba58a4d7bc6019f3ba0ad4774d25a7/Sources/AutoInsetter/AutoInsetter.swift#L121-L124

Needs to respect already-used left/right insets...

I'll need to:

  • Submit a patch to that lib
  • That lib has to update its pod version
  • Then TabMan needs to update?
  • Then we update GitHawk

馃槗

rnystrom picture rnystrom on 28 Jul 2018

Yikes. I guess you could use custom podspecs and forks but that's not ideal 馃槓

BasThomas picture BasThomas on 28 Jul 2018

@rnystrom Just released AutoInsetter 1.2.5 which has the fix included.

Current versions of Tabman are constrained to AutoInsetter 1.2.x releases so a simple pod update should be all you need. 馃槃

Thanks for the patch! 馃帀

cc @BasThomas

msaps picture msaps on 30 Jul 2018
❤1 🎉1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

BasThomas picture BasThomas  路  3Comments
BasThomas picture BasThomas  路  3Comments
BasThomas picture BasThomas  路  3Comments
weyert picture weyert  路  3Comments
jessesquires picture jessesquires  路  3Comments