Githawk: Add “clear” button on all menus

Created on 19 Jul 2018  Â·  3Comments  Â·  Source: GitHawkApp/GitHawk

Labels, milestone, people

Sent with GitHawk

🆕 feature request ✨ good first issue

Most helpful comment

@Maxador you do need permissions to get the ContextMenu (the blue button) to show up on the screen. For a quick hack if you just want to mess with it/ see what it looks like, return [ .labels, .milestone, .assignees ] in this method and you'll get the button to show up on Issues.

Prob want the clear button to look similar to the current done button, possibly in the upper left hand corner. Although, currently Assignees has a leftHand nav bar item so maybe others have ideas about what the UI should look like?

The done button is added in viewDidLoad() of each VC through this method, so you can prob look there for styling cues.

I could be wrong but I don't thinkkk you need to worry about sending any GraphQL mutations or network requests after clear is pressed or the context menu is dismissed, but you probably do need to re-set the selection state of the SectionControllers and update the UI.

All 3 comments

I would like to tackle this issue. Is there more indication on what the “clear” button should look like and how can I access those views with some relevant data?

Sent with GitHawk

@Maxador you do need permissions to get the ContextMenu (the blue button) to show up on the screen. For a quick hack if you just want to mess with it/ see what it looks like, return [ .labels, .milestone, .assignees ] in this method and you'll get the button to show up on Issues.

Prob want the clear button to look similar to the current done button, possibly in the upper left hand corner. Although, currently Assignees has a leftHand nav bar item so maybe others have ideas about what the UI should look like?

The done button is added in viewDidLoad() of each VC through this method, so you can prob look there for styling cues.

I could be wrong but I don't thinkkk you need to worry about sending any GraphQL mutations or network requests after clear is pressed or the context menu is dismissed, but you probably do need to re-set the selection state of the SectionControllers and update the UI.

@BrianLitwin 🔥

Was this page helpful?
0 / 5 - 0 ratings

Related issues

BasThomas picture BasThomas  Â·  3Comments

BasThomas picture BasThomas  Â·  3Comments

rnystrom picture rnystrom  Â·  3Comments

BasThomas picture BasThomas  Â·  3Comments

rizwankce picture rizwankce  Â·  3Comments