Githawk: Missing space when replying to issue comment

Created on 18 Jul 2018  ·  5Comments  ·  Source: GitHawkApp/GitHawk

When replying to a comment in an issue, the text is quoted and you are replying to is automatically pre-filled in the response.
A space after the person you are replying to would be nice, to save the user some time.

Missing space between comment and person by rodrigobdz

❔ question

Most helpful comment

All 5 comments

It would be great if the text bar is expandable like in Slack.app. What do you think? @rnystrom

Sent with GitHawk

All great ideas! Would accept both PRs 😄

All great ideas! Would accept both PRs 😄

@rnystrom could you give me a hint where should I add the space? While digging yesterday, I found this:

https://github.com/GitHawkApp/GitHawk/blob/db6c2c8a3426ffff5ca0b1fafcf366e3298a81a5/Classes/Issues/Comments/IssueCommentSectionController.swift#L141-L156

Actually @jdisho added the reply feature, I’m sure he can point out where might be best!

Sent with GitHawk

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rnystrom picture rnystrom  ·  3Comments

rnystrom picture rnystrom  ·  3Comments

rnystrom picture rnystrom  ·  3Comments

BasThomas picture BasThomas  ·  3Comments

rnystrom picture rnystrom  ·  3Comments