Githawk: Selection bug on Inbox

[rnystrom]

After I refreshed, it’s selecting the first cell and I can’t deselect it. So annoying! Not sure what it’s from.

Bug Report Dump (Auto-generated)

Version 1.22.0 (1531698972)
Device: iPhone X (iOS 11.4)
TestFlight: true

[BasThomas]

Yeah, really weird. As far as I can tell it is pretty random. Sometimes selects everything.

For what it's worth, holding and then dragging deselects the cell.

[rnystrom]

Has to be new, maybe something with the content fading?

_{Sent with GitHawk}

[BasThomas]

Definitely something from the latest beta. Would think it has to be something in the NotificationCell right?

_{Sent with GitHawk}

[BrianLitwin]

add an explicit isSelected = false to the changes in #1908 ?

update: this fixes some highlighting weirdness I get in my simulator. I did a pr w/ this update, think its worth a shot, but might be a band-aid and not a solution, as the odd behavior does seem to be introduced in this new code that iterates over the subviews.

[rnystrom]

Ah found it. It is from #1908. It's iterating over all contentView.subviews and changing their alpha. The dimmable overlay view is a subview. This is an easy fix.