Githawk: Mark as read button still produces haptic after it has already been read

[BasThomas]

Bug Report Dump (Auto-generated)

Version 1.22.0 (1530022158)
Device: iPhone X (iOS 11.4)
TestFlight: true

[maniramezan]

I also noticed it gives Haptic feedback when all messages are already read. What should be the feedback when no unread message exists? Should the button be disabled if no unread message exists?

_{Sent with GitHawk}

[BasThomas]

I don’t think these buttons are enabled/disabled; they work with locations. That said, we should check the trigger and omit the haptic if it has no unreads.

_{Sent with GitHawk}

[BasThomas]

That logic is in NotificationCell.swift.

_{Sent with GitHawk}

[maniramezan]

Sounds good. Thank you for your help. I'll look into it.