Githawk: Don’t set the notification # to 0 if loading fails

[BasThomas]

If you have a certain amount of notifications and then open the app without connection, it will reset the counter to 0.

Bug Report Dump (Auto-generated)

Version 1.21.0 (1528075587)
Device: iPhone X (iOS 11.4)
TestFlight: true

[TheCodeTalker]

you mean to say caching to do here?? @BasThomas

[BrianLitwin]

@BasThomas @TheCodeTalker The classes in charge of this issue are being updated in #1870 so prob re-check this issue after that PR is merged.

[TheCodeTalker]

is this still open ?? @BasThomas @BrianLitwin

[BasThomas]

Yep, still up for grabs.

Re caching: no, that should not be needed.

[TheCodeTalker]

My understanding for this issue if open the app without a connection it should be zero only right because not able fetch the count. @BasThomas

[BasThomas]

When you open the app without a connection, it shouldn't update the badge count (also not to 0).

So for example when you have a badge count of 7, opening the app without connection should not change that. If you close the app again, the badge count should still be 7.

[TheCodeTalker]

ok make sense. i will make a PR

[r-52]

is this one still a problem/ pr worth if no one is working at it?

[BasThomas]

Yep, go for it @romankl!

If there's anything we can help with, let us know.