Githawk: Create Pull Request

[Sherlouk]

• Reuse "Create Issue" UI, will require a small refactor to use a dynamic table view rather than static cells
• Add a choose branch option which opens a modal which displays all branches
  
  
  
  • Will need to work out how to handle forks
  
  

[rnystrom]

I’d actually love to form a partnership with WC and deeplink between the apps. Can you open PRs from WC already?

_{Sent with GitHawk}

[jdisho]

Well, IMO we should add the feature to switch branches in first place. #372

I have never used working copy, but from what I have read here, I assume you can create a merge request.

[Sherlouk]

For context, I was reading this blog:
https://hannesdotkaeuflerdotnet.herokuapp.com/posts/shipping-code-from-the-iphone

The fact they chose to use GitHub web to open the merge request to me insinuates the app doesn't support it?

[rnystrom]

@jdisho ya switching branches would be great

_{Sent with GitHawk}

[rnystrom]

Gonna close this since actually editing code is pretty out of scope for the foreseeable future.

[Sherlouk]

@rnystrom FWIW this definitely wasn't an intention to enable code editing via GitHawk, but more allowing for merge requests to be opened if the changes have already been pushed (for example by another app which itself doesn't support opening them)

One of my use cases is that I push work up, but then want to open a quick pull request so someone can take a look at my changes - branch is there just need to open and write a quick para. Or as Hannes put in their blog, pushed up using Working Copy but then have to use GitHub Web to open the request?

If we were to enable a more flexible (non static) table view for issue creation, this would be pretty easy to do - as well as the ability to support specifying labels/etc on issue creation rather than having to create then edit!

Respect your decision either way though

[rnystrom]

Ah cool, I’ll leave this to you to scope out!

_{Sent with GitHawk}

[Sherlouk]

Updated initial post, should be super low scope to choose branches. I wouldn't even be against top-level (same owner) branches for first iteration then enabling forks but will see the complexity when I (or someone else) picks it up

[rnystrom]

• Show banner in repo overview when a branch has been updated in last 5 (?) minutes
• Tap to create PR
• Submit PR

[Huddie]

I feel like @rnystrom new feature banner is a good starting design for the banner necessary for this feature.

Is there an API that will ease this process or do we need to manually check each of the users repos and branches to detect one that was updated recently, as well as check if its links to some upstream repo which a PR could be made to?

Githubs API (Pull Request)

[rnystrom]

Good idea. We could generalize the banner more

_{Sent with GitHawk}