Githawk: Image rendering issue

[mackoj]

GitHawk don’t render image when they are in a table properly.

| GitHawk | GitHub |
| --- | --- |
| | |

Bug Report Dump (Auto-generated)

Version 1.19.1 (1524679484)
Device: iPhone X (iOS 11.3.1)
TestFlight: false

[rnystrom]

Ya images in tables aren't supported at this time. Would take a little bit of elbow-grease to get this wired up, but not impossible.

[mackoj]

@rnystrom can you give me some pointers on how I can contribute to fix this ?

_{Sent with GitHawk}

[rnystrom]

@mackoj sure thing! This might be a little more complicated than I first thought. Let me know what you think!

Check out how we dynamically download and resize image cells in issues. We cache the sizes as well.

Atm table cells are assumed to be all text. We precompute the sizes and put them in these models. Then we use this cell to display the whole table.

So we'd need to add a new model (or update the existing one) w/ image info, async load the image, and on load refresh the table.

Another tricky part is that the height/width of the image will change the size of the rows/columns of other cells.

[BrianLitwin]

I was trying to approach this issue and got a little blocked. It seems like this file in the cmark-gfm-swift pod would need to be modified to pass in images.. I'm not sure how to go about making modifications to a project dependency.

Also, would it be a good idea or overkill to refactor the current cell that displays the markdown table to use a ListAdapter/ListSectionController, in order to accommodate images and other content?

[rnystrom]

@BrianLitwin ya I think you’re right. Need to update that library as well. The nice part is we can do this in stages, and that library is setup with tests.

Not sure about refactoring to use IGListKit on that. What would we be trying to gain?

_{Sent with GitHawk}

[billybooth]

The same issue applies to images in numbered lists. Not a humongous deal, but it’d be nice to not be missing content altogether, even if the rendering isn’t an exact match. Seeing something like this makes a user question every rendering he or she sees, and forces me to pop any rendering that looks odd into Safari to confirm that I’m not missing something relevant.

Thanks for all of your diligent work on this project. Is there any way we can donate to support this project?

[rnystrom]

@billybooth thank you! Re: donations, I appreciate the thought, but since this is a community operation, I’d rather donations go to a cause in GitHawks name.

http://hispanicfederation.org/unidos/

_{Sent with GitHawk}

[Sherlouk]

Also a review on the App Store is free and helps out the entire project 😉❤️