Githawk: Add “delete branch” support

[BasThomas]

Just had this (https://github.com/twof/CLSwift/issues/9) merged but couldn’t delete the branch from GitHawk. Would be nice maybe? Or too out-of-scope?

Bug Report Dump (Auto-generated)

Version 1.18.0 (1518753170)
Device: iPhone X (iOS 11.2.5)
TestFlight: true

[rnystrom]

Nah I’d love this. Does the API exist?

_{Sent with GitHawk}

[BasThomas]

Oh, that's a good question.

[BasThomas]

You would probably have to do some logic to check if a pull request is merged and all, but yes: https://developer.github.com/v3/git/refs/#delete-a-reference

[rnystrom]

Awesome! Merged state already exists, makes this super easy! We could literally add a floating button. Tho need to make sure the merged branch is part of the same repo.

_{Sent with GitHawk}

[SD10]

Could also be nice to have an Auto Delete Branch setting to handle this automatically after a merge. Don't know if you guys are open to unique features 😛

[rnystrom]

@SD10 hell ya we are! That’s a really cool idea. Anything that speeds up repo management is fair game. I want to get GitHawk into a state where I’d rather not use the .com 😇

_{Sent with GitHawk}

[BasThomas]

Tho need to make sure the merged branch is part of the same repo.

That's including forks right? 😃

Should be noted that if something else still depends on said branch, we shouldn't show the button. Is there an easy way to check that?

[rnystrom]

@BasThomas I’m not sure. For instance, I can’t delete branches from PRs made from forks. That’s what you mean right?

_{Sent with GitHawk}

[SD10]

@rnystrom For example, you can't delete a branch that has an open PR against it. There are definitely some things to consider. I'm not sure how the API would handle such a situation.

[BasThomas]

Yeah, but the other way around. In this case (see image), I forked a repo which was merged; then couldn't delete the branch (on my fork).

[genebean]

Just wanted to add a big +1 for this.