Githawk: Unread badge count should reflect actual unread notifications

[gingerbeardman]

Currently it shows how many notifications are in the inbox, regardless of their read status.

Bug Report Dump (Auto-generated)

Version 1.18.0 (1518753170)
Device: iPhone 6s (iOS 11.2.5)
TestFlight: true

[Sherlouk]

I might be misunderstanding what you mean, but your inbox is your unread notifications. You can swipe to mark the item as read, or use the tick in the navigation bar to mark everything as read.

Entering an issue/PR does not (automatically) mark the content as read as the desktop version does (unless you have the "Read on Open" option enabled in the settings)

[gingerbeardman]

Yes, I have "read on open" set.

For example, this screenshot makes no sense. Especially when you close the app and it still shows the badge.

[BasThomas]

Indeed, seems like we would need to update the badge count if read on open is turned on.

[rnystrom]

Small bug, great starter task for anyone that wants to pick this up! Filtering happens in NotificationsViewController.

_{Sent with GitHawk}

[gingerbeardman]

I'll take a look myself soon

[travjunt]

Should this issue still be open?

_{Sent with GitHawk}

[rnystrom]

@travjunt good call I think this is fine now

_{Sent with GitHawk}