Githawk: Markdown parser broken?

Created on 8 Feb 2018  路  6Comments  路  Source: GitHawkApp/GitHawk

GitHawk Upload by BasThomas
Username is not recognized

GitHawk Upload by BasThomas
Markdown not parsed


Bug Report Dump (Auto-generated)

Version 1.18.0 (1518017959)
Device: iPhone X (iOS 11.2.5)
TestFlight: false

馃悰 bug

All 6 comments

Looks like probably two different issues. The username one is weird, but the link is probably having a # inside it? Will investigate! Should be easy to repro with a unit test

Sent with GitHawk

Referenced issues for easy nav

Moya/Moya#1565

Moya/Moya#1567

Ah so usernames still work, its just the bold style is wrong. Likely from

https://github.com/rnystrom/GitHawk/commit/220a5a3373fba8a8a250e2a3df5a20373c7334dd

Ah that makes sense yeah. Wasn't sure if they were related.

Already fixed locally

simulator screen shot - iphone x - 2018-02-08 at 19 46 19

Hmm something is off still with usernames

Sent with GitHawk

Was this page helpful?
0 / 5 - 0 ratings

Related issues

BasThomas picture BasThomas  路  3Comments

rnystrom picture rnystrom  路  3Comments

rizwankce picture rizwankce  路  3Comments

rnystrom picture rnystrom  路  3Comments

BasThomas picture BasThomas  路  3Comments