Githawk: Squished images

Created on 17 Jan 2018  ·  2Comments  ·  Source: GitHawkApp/GitHawk

GitHawk Upload by BasThomas

Looks fine in NYTPhotoViewer


Bug Report Dump (Auto-generated)

Version 1.17.0 (1515991057)
Device: iPad7,3 (iOS 11.2.1)
TestFlight: true

🐛 bug ✨ good first issue
Source
picture BasThomas

Most helpful comment

How about this content mode?

img{
    max-width:100%;
    box-sizing: border-box;
    max-height: \(Styles.Sizes.maxImageHeight)px;
    object-fit: contain;
}

iPad
simulator screen shot - ipad pro 9 7-inch - 2018-01-17 at 13 27 59

iPhone
simulator screen shot - iphone se - 2018-01-17 at 13 56 34

picture ivan-magda on 17 Jan 2018
👍2

All 2 comments

Caused by the capped heights change, probably just need to change the content mode on the image view

Sherlouk picture Sherlouk on 17 Jan 2018

How about this content mode?

img{
    max-width:100%;
    box-sizing: border-box;
    max-height: \(Styles.Sizes.maxImageHeight)px;
    object-fit: contain;
}

iPad
simulator screen shot - ipad pro 9 7-inch - 2018-01-17 at 13 27 59

iPhone
simulator screen shot - iphone se - 2018-01-17 at 13 56 34

ivan-magda picture ivan-magda on 17 Jan 2018
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

rnystrom picture rnystrom  ·  3Comments
rnystrom picture rnystrom  ·  3Comments
Iron-Ham picture Iron-Ham  ·  3Comments
weyert picture weyert  ·  3Comments
BasThomas picture BasThomas  ·  3Comments