Githawk: Crash when trying to open PR

[Sherlouk]

Opening on behalf of @SD10

App crashes when opening SwifterSwift/SwifterSwift#364

Steps included opening the PR fine initially
Beginning to write a response
Clicking a link to a file (which opened our SafariVC)
Clicked done before the file had loaded
Navigated back to index
and now can't get back into the PR

The response included a mention and some text, possibly related or maybe not
Can't reproduce on my phone (can view the PR just fine though)
Latest TF

Crash Report

[Sherlouk]

REPRODUCIBLE

Step 1: Load an Issue or Pull Request
Step 2: Begin to write a new comment, make sure you add a new line
Step 3: Press Back to leave the Issue
Step 4: On trying to re-enter, it'll crash

@rnystrom @SD10

[BasThomas]

Crashes here because the scrollView is nil.

[Sherlouk]

Any idea on a fix, besides obviously just inserting a ? to avoid the issue 😅

Clearly layout is getting called from a notification which is being triggered before setup

Move the observers to after we call setup?

[Sherlouk]

Link to crash on Fabric: http://crashes.to/s/34f0223ea50

[SD10]

Great work on this @Sherlouk 👏