Githawk: See more bubbles sometimes spawn on wrong comment

[SD10]

The bubble on pyraniq's comment seems to be linked to the bubble for the main post of the PR:

If I expand the original post, both bubbles disappear. If I try to double tap on the bubble for pyraniq's comment, it gives the main post a thumbs up. Using FLEX it looks like these are the same view 🤔

[Sherlouk]

We not hiding it on prepare for reuse maybe?

[rnystrom]

@Sherlouk I bet you’re exactly right

_{Sent with GitHawk}

[Sherlouk]

Ahh think I found the fault: https://github.com/rnystrom/GitHawk/pull/1406/files#diff-7a2ac7b42147b46d47c53153b3ab62fbR287

We cast to a base cell, in the screenshot above it's a review cell which AFAIK is handled differently
So yea it's most likely a prepare for reuse, but caused by the above line not matching

[rnystrom]

@Sherlouk aha! Great find. Wanna PR it real quick?

_{Sent with GitHawk}

[Sherlouk]

Actually I was wrong, review cells can cast to IssueCommentBaseCell - so actually not sure

[SD10]

EDIT:

• If you just pull down to refresh on MessageKit #458 you will see it spawns 4 bubbles.
• If you go to home, then re-enter app. You will end up with 2 bubbles.
• While scrolling they appear/disappear randomly.

Hopefully helps with debugging