Githawk: Comments render white space

[BasThomas]

Happens on both iPad and iPhone. Have a feeling it’s been happening more the last few days? Also happened on previous version though.

Bug Report Dump (Auto-generated)

Version 1.17.0 (1514903367)
Device: iPad7,3 (iOS 11.2.1)
TestFlight: true

[BasThomas]

Issue in question: https://github.com/Moya/Moya/issues/1523

_{Sent with GitHawk}

[rnystrom]

Hmm @BasThomas can you do some debugging here? I can't repro.

[SD10]

The spacing is even larger in the latest TestFlight: 1.17.0

I think it’s also making scrolling extremely choppy.

_{Sent with GitHawk}

[BasThomas]

Haven’t seen it lately - can you tap with three fingers to dig a bit with FLEX?

_{Sent with GitHawk}

[SD10]

Sorry @BasThomas I don’t know what you mean.

It’s difficult to reproduce but once it happens, any comments have an excessive amount of spacing on any issue throughout the app. Once I kill GitHawk and reopen it’s gone.

It has happened by viewing an issue on a fresh app start, expanding a comment, posting a comment. Can’t single it down to one specific action and it’s inconsistent.

_{Sent with GitHawk}

[BasThomas]

In Testflight, you can tap with three fingers anywhere on the screen to have additional tools (see image), which enable you to debug the views, network requests and more.

_{Sent with GitHawk}

[SD10]

Sorry @BasThomas, noob moment. Thanks for getting me up to speed!

_{Sent with GitHawk}

[BasThomas]

@SD10 have you been seeing it in the last few days / been able to debug with FLEX?

[SD10]

I haven't seen any but I've had very limited GitHub activity in the past few days. We could close and re-open if I see it again

[rnystrom]

I think I saw this today caused by html comments and no actual content. Will investigate.

_{Sent with GitHawk}

[Sherlouk]

https://github.com/SwifterSwift/SwifterSwift/pull/364

Not sure if the same bug, but the root comment in here has a bunch of HTML comments which render as massive blocks of white space in app

[SD10]

Steps to reproduce:

1. Open any issue / PR
2. Immediately stop view from scrolling to bottom
3. White space appears on all comments made through GitHawk and other HTML blocks

_{Sent with GitHawk}

[rnystrom]

@SD10 hmmm I can’t seem to repro that. The html comments are definitely a thing though. I’m going to fix those for 1.17

_{Sent with GitHawk}

[rnystrom]

PR fixes this big time, but still want to strip commented HTML out. For example, that Moya issue is totally empty.

[rnystrom]

Seems to be fixed