Githawk: Change constraints for View Layouts to better support RTL

Created on 16 Dec 2017  ·  6Comments  ·  Source: GitHawkApp/GitHawk

I've noticed that a couple constraints use .left and .right instead of .trailing and .leading. I would suggest doing an RTL audit if you have the chance!

🐛 bug

All 6 comments

@BasThomas think this is easy as easy find/replacing left & right with leading/trailing?

Would be awesome to even flip layouts like the header and reactions

Sent with GitHawk

This would be so awesome! Thanks for reporting this mr breakdance 😉

@rnystrom only one way to find out! There this amazing talk from WWDC 2016 that you should watch if you're interested.

Now that I've looked it up again I'll definitely rewatch - not sure if I can take a look a this ticket soonish though, so feel free to pick it up.

Re flipping everything: yessss! There are a few exceptions though, as is also discussed in the linked video (timestamp here).

Some screenshots to give an idea of the current state (ignore the CAPITALIZATION; Xcode does that when testing with a Right-to-Left Pseudolanguage 🤷‍♂️):

screen shot 2017-12-17 at 16 23 59
screen shot 2017-12-17 at 16 24 07
screen shot 2017-12-17 at 16 26 06

That looks pretty amazing for a simple find/replace. With a little bit of tuning, we'll have this all sorted.

No, this is without find/replace, just as it is right now!

Wo! That's not too bad.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rnystrom picture rnystrom  ·  3Comments

BasThomas picture BasThomas  ·  3Comments

BasThomas picture BasThomas  ·  3Comments

BasThomas picture BasThomas  ·  3Comments

BasThomas picture BasThomas  ·  3Comments