Githawk: Tapping whitespace does not expand comment

Created on 6 Dec 2017  ·  5Comments  ·  Source: GitHawkApp/GitHawk

It was not obvious to me that it was possible to expand the comment. Maybe it should also be on the triple dot menu?

Tapping to expand the comment requires you to tap on text in the comment, rather than anywhere in the comment. Tapping whitespace does not expand the comment.

  • If I tap the whitespace to the right of "Description" it will not expand the comment.
  • If I tap "Decription" it will expand the comment.

https://user-images.githubusercontent.com/739696/33625188-c979f486-d9c4-11e7-98da-6d2f7ca8ad79.png

🐛 bug ❔ question

All 5 comments

Oh wow yup, I can repro this. I think it’s a regression.

Sent with GitHawk

I'm wondering if only long comments could be truncated?

I've not looked at your code, sorry.

@gingerbeardman they are! Only comments that exceed 300 pts in height are collapsed. Here's the code:

https://github.com/rnystrom/GitHawk/blob/master/Classes/Issues/Comments/IssueCollapsedBodies.swift#L20-L42

Rather than an arbitrary amount maybe factor in whether or not the comment contains quote/code? I don't mind long comments, it's just ones with quotes, code or logs that I don't want to see in full.

@gingerbeardman love it! Mind splitting off a new issue?

Sent with GitHawk

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rnystrom picture rnystrom  ·  3Comments

BasThomas picture BasThomas  ·  3Comments

BasThomas picture BasThomas  ·  3Comments

weyert picture weyert  ·  3Comments

BasThomas picture BasThomas  ·  3Comments