Githawk: Add separator between review comments

Created on 2 Dec 2017  路  8Comments  路  Source: GitHawkApp/GitHawk

Now only distinguished by avatar. Should probably use the same separation style as comments in an issue / PR.

GitHawk Upload by BasThomas


Bug Report Dump (Auto-generated)

Version 1.15.0 (1511968511)
Device: iPhone X (iOS 11.2)
TestFlight: true

Most helpful comment

image

Problem Solved :trollface:

All 8 comments

I was trying to keep the thread UI consistent with PR review threads on GitHub.com. The separator isn鈥檛 there so it鈥檚 more clear that it鈥檚 a continuous conversation. Different threads get separators, a diff hunk, and file.

I鈥檒l enable separators and see how it looks.

Sent with GitHawk

That's a good point; on web you have this vertical line, but we can't have that unless we inset the text to the right... which due to size constraints I wouldn't do 馃槢

screen shot 2017-12-02 at 21 01 22

image

Problem Solved :trollface:

so beautiful

Gonna say its too busy

img_0232

I actually think it looks nice with the blue headers where it's "you" -- could we do a very faint grey for anybody but "you"?

@rnystrom 馃

The blue headers are already there; the gray horizontal lines aren't. @Sherlouk

@BasThomas Yea I know! I'm suggesting we don't have the lines, but have a light grey background on all other users 馃槃

Was this page helpful?
0 / 5 - 0 ratings

Related issues

BasThomas picture BasThomas  路  3Comments

BasThomas picture BasThomas  路  3Comments

rnystrom picture rnystrom  路  3Comments

BasThomas picture BasThomas  路  3Comments

BasThomas picture BasThomas  路  3Comments