Githawk: FBSnapshot Tests Broken

Created on 25 Nov 2017  路  3Comments  路  Source: GitHawkApp/GitHawk

Looks like the FBSnapshot tests were never functional on CI, but as CI was broken for other reasons we didn't realise! 馃槥

As part of the work done in #1075 to fix all of the CI issues the tests have been commented out, we should add them back and get them fully functional to start reaping the rewards!

@Austinate - Are you able to help out at all with this?

馃悰 bug

Most helpful comment

Hm, that's strange, sorry for that.
Will take a look

All 3 comments

Hm, that's strange, sorry for that.
Will take a look

After investigation i can say that part of issue was that i forgot to make Freetime scheme a shared one (so i only had 'environment variables' locally).
This is easily fixable.

Another part i realized right now is that for full-VC snapshots we will need snapshot-per-device or we should probably decide which device we will use for snapshot testing. (Also there is a same requirement for 2x/3x snapshots, we would need to make both or lockdown on 1 device probably).

Closing since I'm not sure this is worth the time

Was this page helpful?
0 / 5 - 0 ratings

Related issues

weyert picture weyert  路  3Comments

rnystrom picture rnystrom  路  3Comments

BasThomas picture BasThomas  路  3Comments

BasThomas picture BasThomas  路  3Comments

BasThomas picture BasThomas  路  3Comments