Githawk: Can't build master at the moment

[Sherlouk]

@BasThomas @rnystrom

😢

[BasThomas]

Up to date with master? This is what was happening before #1039

[BasThomas]

Or at least, this was happening before I recloned the repo I think?

[Sherlouk]

Did a fresh fetch and that's what's happening

Generate Secrets config is before the CP stuff, so that fix has gone in

🤔

[BasThomas]

But the xcconfig isn't generated yet looking at your screenshot?

[BasThomas]

Did you build or run?

[Sherlouk]

Run, I just did a clean and build and it went through, So maybe false alarm

Though maybe it is an issue where you have to build twice because of the order of events

[BasThomas]

I think you have to specifically build the first time, as for some reason run doesn't invoke the script. Not sure.

[Sherlouk]

Buddybuild still broke as well, so something's definitely up!

[BasThomas]

Ugh, you're right

[rnystrom]

God this is so frustrating. Tempted to just revert all of the changes so I can actually focus on building things instead of fighting blackbox tools.

So its working locally, even cloned a new repo and got it to work out of box. I assume that buddybuild is using their own config or something.

I'm pretty stuck at the moment. Any ideas?

[Sherlouk]

Genuinely I'm just unsure how the whole ObjC bit fits in, I feel we could use ProcessInfo.processInfo.environment to get the environmental variables. They can be set via the scheme that way, and BB uses env variables AFAIK so should be fine!

Removes all this complexity with .xcconfig etc, but yea I'm easy

[rnystrom]

@Sherlouk sounds great, mind putting up a PR to change that?

_{Sent with GitHawk}

[rnystrom]

@Sherlouk just checking, are you able to help with this? Would be really appreciated. I tried using the env vars and got stuck.

_{Sent with GitHawk}

[Sherlouk]

Sorry yea will pick this up today! (DIdn't actually get a notification for the first comment 🤔)

[Sherlouk]

@rnystrom What's the goal here, what do we want to achieve?

Is it that BuddyBuild can define these constants without your intervention? Or is it that the app can't build if you don't define them? or what?

[rnystrom]

• Switch branches and pull without changing keys
• Don’t check in keys
• Using fastlane locally will fail if keys aren’t set
• CI builds with keys
• Not flaky

_{Sent with GitHawk}

[BasThomas]

How's this coming along?

[Sherlouk]

I wanna say it's done, but will leave that to @rnystrom

Know there was a few teething issues, but think they're fine???

[rnystrom]

Ya I think this is ok now

_{Sent with GitHawk}