Githawk: Missing Notifications

[Sherlouk]

GitHawk had 2 less notifications than I had on the web version 😞 I know we've had this in the past, but has anyone else experienced it recently?

[BasThomas]

Not experienced it recently. Were those on web notifications for code changes? I think these might be ignored / wrongly parsed on our side and slip through?

[Sherlouk]

Yea commits in PRs, intriguing

[BasThomas]

Think this is a different issue than them not appearing until kill+relaunch, but definitely a bug we should fix.

_{Sent with GitHawk}

[Sherlouk]

I did kill + relaunch though 🤔 😞

[BasThomas]

I know - but that didn’t fix it right?

_{Sent with GitHawk}

[Sherlouk]

Nope, still didn't appear! #blameGitHubAPI

[BasThomas]

Exactly. Thing is - I don't think it's the fault of the GitHub API, but us. At least we get the notification count from GitHub...

[BasThomas]

See also here

[Sherlouk]

Let's keep discussion in 121 then to follow this (didn't see that issue!)

[Sherlouk]

@BasThomas Reason for re-open? Fix is in :)

[BasThomas]

Wait what where?!

_{Sent with GitHawk}

[BasThomas]

Nvm, I see it now (#949)

_{Sent with GitHawk}