Githawk: Focus keyboard as “new issue” presents

[rnystrom]

Feels a little jerky. The keyboard pops into place as the VC is animating. Could we animate it together somehow? Maybe a custom transition coordinator?

Being picky, but putting this tiny polish on stuff is fun 😇

Bug Report Dump (Auto-generated)

Version 1.12.0 (1166)
Device: iPhone 7 Plus (iOS 11.1)
TestFlight: false

[rnystrom]

Created a quick hack to do this. Feels pretty smooth. I'll work on cleaning this up and making it a more permanent part of the app. Will also figure out better modal presentation animations for iPad (maybe just not use this on iPad...)

ViewControllerKeyboardAnimated.zip

Gist of the interesting code

Animation:

[rnystrom]

So edit comments, new issue, and report bug will benefit from this. Their transitions are a little inconsistent atm.

_{Sent with GitHawk}

[weyert]

Interesting approach, may I ask why you have hard-coded 0.3 in one delegate call while in the other parts you seem to get it from the keyboard notification?

[rnystrom]

Good point, I'll use the current value and fallback to 0.3 if we haven't gotten a time from the keyboard yet. I need to put some BPs in there and see the order of operations...

[rnystrom]

I tried using the gist above and got some weird behavior. I'll dig into it later. This also breaks on iPad. I'd rather have an unsynchronized keyboard animation over bad iPad support.

[BasThomas]

This still an issue?

[rnystrom]

Nope!

_{Sent with GitHawk}