Githawk: Bookmark test failing

[rnystrom]

https://dashboard.buddybuild.com/apps/59d904ff8588d60001729c4e/build/59ff60e1a8cf4d0001a7e4c2#logs

    Failing tests:
        BookmarkStoreTests.test_duplicateBookmarks()
    ** TEST FAILED **

[rnystrom]

First local test run, all green. After another run test_bookmarksFromDifferentUser fails.

Seems like there is some state sticking around between test runs or something.

[rnystrom]

Yup, these tests are initializing new stores and then never clearing state, so they just needlessly accumulate stuff and disk and fail after the first run. cc @rizwankce

[rnystrom]

Also hashValue is for Hashable, NSObject subclasses w/ custom hash+equality need to override hash and isEqual. Lastly, updating the equality method to actually check all values.