Githawk: Only initial login works with SFAuth

[BasThomas]

Setup auto-logs in when previously logging in on Safari, but then accessing an issue or permissions needs logging in again

Bug Report Dump (Auto-generated)

Version 1.12.0 (1137)
Device: iPhone10,6 (iOS 11.1)
TestFlight: true

[rnystrom]

Oh weird shouldn’t it all use the same thing? Did SFAuth not get added to login?

_{Sent with GitHawk}

[BasThomas]

I think it's the other way around?

[joerocca]

SFAuthenticationSession doesn't share the session with SFSafariViewController.

[rnystrom]

@joerocca what is AFAuthenticationSession?

[joerocca]

@rnystrom oops, typo!

_{Sent with GitHawk}

[rnystrom]

Haha, I read it as AFAuthenticationSession doesn't share w/ SFAuthenticationSession, now I see it. Here's how I see our options:

• Revert the SFAuthenticationSession stuff. This stinks b/c then if you have an active GitHub session in Safari.app, you can't take advantage of that.
• Remove the setting
• Have the setting openURL to Safari.app
• Leave it alone (maybe add a subtitle/disclaimer that might have to login again)

I guess this calls out a larger issue that our use of SFAuthenticationSession+SFSafariViewController is going to result in an inconsistent experience. Even if you open stuff like profile in a webview, you wont be logged in yet.

Sort of makes me lean towards reverting SFAuthenticationSession until we have 0 SFSafariViewController.

Thoughts?

[BasThomas]

Yeah, I'd go for reverting it. Also feel like the 0 SFSafariViewController isn't really something we can achieve soon. Having to log in just the once would make more sense then being logged in automatically but then finding you have to login again for certain webviews.

[joerocca]

Yeah, this is a tough choice because reverting will reopen #426. Is not having to log in again in safari worth losing the ability to log out? I feel like having to log in to safari is more of an inconvenience whereas inability to log out is a problem.

[rnystrom]

Ack that’s true. Uggggh. Maybe we just leave it alone then. Not being able to log out is pretty bad too.

_{Sent with GitHawk}

[rnystrom]

Ok I think we should open permissions into Safari.app since SFAuthenticationSession shares info w/ Safari. Issues can only be opened in Safari.app anymore, and stuff like profile will eventually be native.

Everyone ok w/ this? @joerocca @BasThomas

[BasThomas]

Not loving it, but I get the reason. What about “view source code”, do you want to redirect that to the native repo view, maybe deeplinked to the code tab?

_{Sent with GitHawk}

[joerocca]

Yeah, I️ think that is the best compromise.

_{Sent with GitHawk}

[rnystrom]

I’m not as concerned about the view source yet. I think GitHub offers more browsing tools and stuff. If we had a way to share out of the native code section I’d say ya.

_{Sent with GitHawk}