Githawk: Code file viewer loading while already showing contents

[BasThomas]

Bug Report Dump (Auto-generated)

Version 1.12.0 (1106)
Device: iPhone 7 Plus (iOS 11.0.3)
TestFlight: true

[rizwankce]

when is this exactly happening? Maybe step to reproduce would help.

[BasThomas]

Seems like it's happening quite a lot, especially when reloading (so if you viewed said file before).

So, steps to reproduce:

Open code browser
Open file
(optionally) go back and open the same file

[rnystrom]

Does the loading indicator go away? What exactly is the issue?

_{Sent with GitHawk}

[BasThomas]

It does, just weird that it seems to be loading still when the file’s already there.

_{Sent with GitHawk}

[rnystrom]

There’s a min delay on the refresh indicator, prevents it from flickering closed when the response is quick. We could change this to how Feed.swift does it and wait for the didAppear event, check if loading, then display. That’ll stop it from appearing at all when the network is snappy.

_{Sent with GitHawk}