Githawk: Inconsistent nav bar back button

Created on 24 Oct 2017  路  4Comments  路  Source: GitHawkApp/GitHawk

In some place, we show nav with a left button with text as "Back". In some place, we just show without the text.

Also, we do have a UIViewController extension makeBackBarItemEmpty to make it empty and it is used in less place. Is it expected? or we should be using empty back button throughout the app.

With Text

screen shot 2017-10-24 at 10 36 48 am

Without Text
screen shot 2017-10-24 at 10 37 18 am

馃啎 feature request

Most helpful comment

Yes - but the system will remove the back bar if it would need more space for the title automatically. :)

All 4 comments

I feel like we should default to what the system gives us; which means to not make it empty on purpose.

I like nav bar back without the text. It gives more space for our title

Yes - but the system will remove the back bar if it would need more space for the title automatically. :)

We should

  • Clear the text in almost all cases (use the extension)
  • Keep the text for root > next transitions (eg Inbox > Archive transition)

Sent with GitHawk

Was this page helpful?
0 / 5 - 0 ratings

Related issues

BasThomas picture BasThomas  路  3Comments

BasThomas picture BasThomas  路  3Comments

BasThomas picture BasThomas  路  3Comments

BasThomas picture BasThomas  路  3Comments

rnystrom picture rnystrom  路  3Comments