Githawk: Tap reaction to +1 and the use menu for same emoji lets you react twice

[rnystrom]

API figures this out and negates the second, but our UI +1s twice which is wrong.

Bug Report Dump (Auto-generated)

Version 1.11.0 (1943)
Device: iPhone 7 Plus (iOS 11.0.1)
TestFlight: false

[BasThomas]

Uh-oh.

[BasThomas]

Should it noop or remove the +1?

[rnystrom]

Good question. I think no-op since the menu is sort of an additive action.

_{Sent with GitHawk}

[Sherlouk]

https://github.com/rnystrom/GitHawk/blob/a904020a1c2c7a2b2d1d233451be60cc418d92d2/Classes/Issues/Comments/Reactions/IssueCommentReactionCell.swift#L102

Could we just not add items to the action array if it already exists in the tray? Keep it as a purely "add a new reaction"?

Out of curiosity what's stopping us from just having all of the reactions visible but with the label at 0 and slightly faded? 🤔

Additionally the desktop UI just removes the +1 if you already have it selected. Similar problem? Same solution?

[Sherlouk]

Maybe better still:

https://github.com/rnystrom/GitHawk/blob/a904020a1c2c7a2b2d1d233451be60cc418d92d2/Classes/Issues/Comments/Reactions/IssueCommentReactionCell.swift#L117-L125

We could return false here if the user has already selected it, this essentially disables the button but keeps it visible?

[rnystrom]

All the reactions visible looks super sloppy. Puts more strain on you to find what is the most popular reaction, etc. Im also trying to keep GitHawk’s UI consistent with GitHub so you don’t have to learn new behaviors.

_{Sent with GitHawk}

[BasThomas]

You can even get up to 1000 reactions atm if you want 😁