Githawk: Landscape view overlap for Login

Created on 1 Oct 2017  路  2Comments  路  Source: GitHawkApp/GitHawk

This looks like a constraint issue in LoginSplashViewController.
Note: Only affects iPhone, iPad is fine.

Steps to Reproduce

  1. Launch app in unauthenticated state or log out
  2. Rotate the screen if you're in portrait orientation
  3. Observe that the subtitle label overlaps the sign in button.

Screenshots

iPhone 6S

simulator screen shot - iphone 6s - 2017-10-01 at 14 24 56

iPhone 6S+

simulator screen shot - iphone 6s plus - 2017-10-01 at 14 27 18

Version 1.10.0 (1900)
Device: iPhone 6s (iOS 10.3.3)
TestFlight: false

馃悰 bug
Source
picture ajfigueroa

All 2 comments

A simple approach I took was to use size classes and approximately halve the constraint values for Landscape.

Let me know what you all think and I can put together a PR?

simulator screen shot - iphone 6s - 2017-10-01 at 16 40 58

ajfigueroa picture ajfigueroa on 1 Oct 2017
❤1

You're more than welcome to submit a pull-request and I'll take a look at it - probably won't get merged for another week or so though until Ryan get's off his holiday!

The screenshot definitely looks better though!

Sherlouk picture Sherlouk on 1 Oct 2017
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

rnystrom picture rnystrom  路  3Comments
viktorgardart picture viktorgardart  路  3Comments
weyert picture weyert  路  3Comments
BasThomas picture BasThomas  路  3Comments
rnystrom picture rnystrom  路  3Comments