Githawk: Enforce Swift style and conventions

Created on 26 Sep 2017  路  4Comments  路  Source: GitHawkApp/GitHawk

https://github.com/realm/SwiftLint

Bound to get a whole load of warnings on first usage but think it would be worthwhile getting things a bit more readable and consistent!

If we do it, I'd vote for putting the portable binary into the repo like license-plist so we don't have issues of users have different versions of swiftlint installed

馃幆 project management

Most helpful comment

@Sherlouk what'd win me over is seeing what this looks like in practice. Maybe we start _really_ lightweight, only linting really "obvious" common stuff. Then as things repeatedly come up we can opt into more lints?

All 4 comments

As long as it doesn鈥檛 get in my way then it鈥檚 probably fine 馃槅

I鈥檓 pretty conservative about dependencies and am starting to get a little anxious about all the stuff we鈥檙e adding. Just don鈥檛 want to get bogged down with scattered deps/tools that don鈥檛 actually increase the quality of the delivered app.

Agree this could help other contributors stay consistent tho.

Sent with GitHawk

@rnystrom Completely up to you at the end of the day, it's not going to improve the app, nor help prevent bugs but it does help against every contributor having their own standards of how things should be laid out.

Ultimately if you're happy with the state of the repo then we can continue as is and just leave this issue until a point where it's felt necessary

@Sherlouk what'd win me over is seeing what this looks like in practice. Maybe we start _really_ lightweight, only linting really "obvious" common stuff. Then as things repeatedly come up we can opt into more lints?

Agree with @rnystrom - it's easier to add rules if we feel the need then adding them all at once (or even removing some at some point). Let's start easy.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

BasThomas picture BasThomas  路  3Comments

BasThomas picture BasThomas  路  3Comments

rnystrom picture rnystrom  路  3Comments

weyert picture weyert  路  3Comments

BasThomas picture BasThomas  路  3Comments