Githawk: Update GitHub settings so auth makes sense

[rnystrom]

https://twitter.com/hansemannnn/status/912048068698234881

[Sherlouk]

Ha just mentioned this in #418 but yeah got to make sure we release and update on GitHub at same time otherwise people won't be able to login 😱

[BasThomas]

Also, we should update the docs

[BasThomas]

@Sherlouk that’s a tricky one then. Would break all previous versions of the app... if we want to go that route, we might want an intermediate release so we can then show a dialog asking users to update again? Not sure if that would help / make sense.

[rnystrom]

Ya I don’t want to do break any backwards compatibility. I haven’t explored what display options I have on the GitHub app yet either. At the very least I could change the callback url.

_{Sent with GitHawk}

[Sherlouk]

The only way to have complete backwards compatibility is to keep it as freetime://, obviously we could do forced upgrade but I'm not always a fan

My thoughts behind my original comment is that a user of the app will "most likely" have logged in. Which means the only people who are going to have issues, are new people trying to log in who "should" be on the latest version as they're new! By that logic, if we push the app out first with the new callback URL then it shouldn't be too bad in terms of breaking for users.

Obviously the easier solution here is just make another Oauth application on GitHub with the URL set to githawk:// and in the new release just update everything to reference the new scheme and the new oauth application. Seamless transition, in a couple weeks/months just delete the old application on GitHub (if you care)

[rnystrom]

Ya, I think just creating a new Oauth app is the way to go. Should I create a GitHawk-App org/user so the text reads as "Authorize GitHawk-App"?

[Sherlouk]

Sure!

[gingerbeardman]

Why does CodeHub not have the auth issues GitHawk has? Since the privacy change that came with the Microsoft buyout, I'm able to interact with less and less repos

[rnystrom]

@gingerbeardman the name issue? What was the privacy change?

_{Sent with GitHawk}

[gingerbeardman]

Basically I have to request reach repo to allow GitHawk client permission for me to comment or like

[gingerbeardman]

Basically this for every repo @rnystrom : https://github.com/GitHawkApp/GitHawk/issues/1858

[rnystrom]

Was that a broad privacy change?

_{Sent with GitHawk}

[gingerbeardman]

Yes, I'll try to find some references

[gingerbeardman]

Not a reference, but the first time for me that a repo has declined to allow GitHawk access.

https://github.com/fman-users/fman/issues/455

[gingerbeardman]

What is the app doing that means it doesn't have access without approval to so many repos? I get this nag so often and it drives me nuts.

[j-f1]

@gingerbeardman If you use a personal access token, you shouldn’t have any issues.

[gingerbeardman]

@gingerbeardman If you use a personal access token, you shouldn’t have any issues.

@j-f1 I'm not sure what you mean? How do I use a PAT with GitHawk to solve these OAuth nags?

[gingerbeardman]

@gingerbeardman If you use a personal access token, you shouldn’t have any issues.

@j-f1 I think I figured it out - thank you!