Githawk: Add toggle to switch between open and closed issues/PRs on repos

[rnystrom]

Probably just put a unit at the top of the list?

[Sherlouk]

Relates to #287

_{Sent with GitHawk}

[ijm8710]

Is there any roadmap to add a open/closed toggle. #287 is closed itself

[BasThomas]

I think we can close this, unless we want to revisit the way we do this soon. Closing for now; feel free to reopen if anyone feels this needs improvement.

[ijm8710]

@rnystrom what were your thoughts on the value of tabbed or toggle options between open/close. As is I have to retype the word closed on the default open identifier. Saw in a chain you intentionally leaned primitive to start, but curious if you see value to polishing that or if you prefer to keep as is.

[rnystrom]

Ya I’d love at the very least a form or picker to make this easier. Right now it works but you have to know how to do all the filters.

It’d be cool to have like a filter icon/button in the bar. Tap it and we show a context menu form with all the options where you can select and enter all sorts of stuff (labels, status, etc) and maybe a link to GitHub search documentation for more advanced stuff.

_{Sent with GitHawk}

[ijm8710]

@rnystrom can we reopen this then, or merge if there’s an active ticket :)

[Huddie]

2679 has my design suggestion.

I think it’s a good easy start.

@BasThomas, thoughts on this design? Possibly alternatives?

_{Sent with GitHawk}

[BasThomas]

I like it (and your handwriting). Not sure if that works with a standard UISearchController however. Can you take a stab at this in code and see what it'd look like?

If that doesn't work, what could be an alternative?

[Huddie]

I’ll try to code it up and think of alternatives as well. Not sure of a good alt. that doesn’t take up real estate

_{Sent with GitHawk}

[BasThomas]

Yeah, it would then quickly take up real estate. I really like the current sketch, but that would also take away quite a size from the search bar horizontally... 🤷‍♂️

[Huddie]

That’s true but no more is:open necessary which opens up some text. I guess we’d have to see could be it takes up too much space

_{Sent with GitHawk}

[Huddie]

@BasThomas turns out is not a SearchBarController :D lucky me. Just another cell, easy to manipulate. Check out #2687