iPhone X makes the status bar alert outdated. Need to find something new. Any ideas?
rnystrom
All 22 comments
Same style of alert but pops up as a toast above tab bar or cover nav bar? Or we just address it on a case by case basic and try to give more contextual error messages
Sherlouk
on 17 Sep 2017
Really like the toast idea. Lets go hunting!
Sent with GitHawk
rnystrom
on 17 Sep 2017
https://github.com/devxoul/Toaster - Very quick search is showing this, gives appareance overrides so with a couple factory methods we can distinguish between errors/other messages?
Sherlouk
on 17 Sep 2017
I have made a pull request #483 that implements https://github.com/devxoul/Toaster
I looks nice, maybe some more minor layout changes
kimdv
on 2 Oct 2017
As @rnystrom mentioned in #483 we should make our own. 😄
kimdv
on 4 Oct 2017
Started work on this on the flight home. Will have something pretty soon! Came up w/ some fun ideas. Building it in a way so it can be a separate pod. Love @BasThomas's idea.
rnystrom
on 9 Oct 2017
Quick preview of what I've got in action:
Features:
- Totally configurable (text, font, colors, layout spacing)
- Interactive
- Rubber-band effect when swiping up
- Swipe down to dismiss
TODO:
- Auto dismiss after duration
- Delegate when tapping button
- Fix multi-line label
- Tune physics
Learned quite a bit about UIDynamics and Auto Layout w/ this. Been fun!
rnystrom
on 13 Oct 2017
Oh wow, looks great! Looking forward to seeing how you implemented it 😀
Sent with GitHawk
BasThomas
on 13 Oct 2017
That image was very confusing from the app's point of view, it just looks like an image 😅
Looks great though! (when looked at on GitHub)
Sherlouk
on 13 Oct 2017
Yeah, the “Quick preview of what I’ve got in action:” definitely helped though. Gif support please! 😁
BasThomas
on 13 Oct 2017
It's weird though because NY photo viewer supports GIFs, so... it should've worked 🤔 Maybe we have to enable it some how
https://github.com/rnystrom/GitHawk/blob/master/Podfile.lock#L17-L22
Sherlouk
on 13 Oct 2017
Oh that's weird. No idea.
BasThomas
on 13 Oct 2017
@BasThomas Looks like you have to add ANIMATED_GIF_SUPPORT as a compiler flag to get it working. If you get five minutes 😉
https://github.com/NYTimes/NYTPhotoViewer/blob/master/NYTPhotoViewer/NYTScalingImageView.m#L21
Sherlouk
on 13 Oct 2017
Can we close this now, @rnystrom?
BasThomas
on 13 Oct 2017
@Sherlouk that gives me a "no such file or directory" 😂
What am I missing?
BasThomas
on 13 Oct 2017
For reasons I don't understand, ya have to prefix them with -D so -DANIMATED_GIF_SUPPORT
Sherlouk
on 13 Oct 2017
🤔, it seems like it should already work without though: https://github.com/NYTimes/NYTPhotoViewer/blob/14458e8ed8065c3cf31fe0744db9fd4c506e4cfe/NYTPhotoViewer.podspec#L25
BasThomas
on 13 Oct 2017
I don't understand because we don't even specify a subspec: https://github.com/rnystrom/GitHawk/blob/master/Podfile#L12
and it doesn't specify a default subspec 🤔 Maybe reference the NYTPhotoViewer/AnimatedGifSupport directly?
Sherlouk
on 13 Oct 2017
Also @BasThomas https://bugs.swift.org/browse/SR-909 -- Is this applicable?
Sherlouk
on 13 Oct 2017
Doesn't look like it. #if ANIMATED_GIF_SUPPORT is true.
BasThomas
on 13 Oct 2017
Not too familiar with ObjC, is #ifdef handled differently?
Is it getting to https://github.com/NYTimes/NYTPhotoViewer/blob/master/NYTPhotoViewer/NYTScalingImageView.m#L125?
Sherlouk
on 13 Oct 2017
Let's move this over to #75
BasThomas
on 13 Oct 2017
Related issues
BasThomas
·
3Comments
BasThomas
·
3Comments
weyert
·
3Comments
rnystrom
·
3Comments
rizwankce
·
3Comments
Most helpful comment
Quick preview of what I've got in action:
Features:
TODO:
Learned quite a bit about UIDynamics and Auto Layout w/ this. Been fun!