Githawk: Add # autocomplete for issue references

[BasThomas]

Version 1.4.0 (1136)
Device: iPhone 7 Plus (iOS 10.3.3)

[rnystrom]

Absolutely!

[TheCodeTalker]

  func fetch(
        owner: String,
        repo: String,
        number: Int,
        width: CGFloat,
        prependResult: IssueResult?,
        completion: @escaping (IssueResultType) -> ()

is IssueResult contains issue references or how can i get those objects ?? i have make a seperate call or what . @rnystrom

[rnystrom]

Did a quick investigation, this might be too difficult w/ just number autocomplete. None of the APIs provide a way to search via the number. All of the search is done by matching text in the title, body, or comments (ref).

How about we change this to do a search like "#search" that autocompletes issues w/ the word "search" in them? The comments UI works like this now.

Now the question is if we use the v3 API (ref above) or the GraphQL API. Haven't dug on what is better suited, but probably the GraphQL API.

@TheCodeTalker in that case we'll need to build a new query for this.

[BasThomas]

That's not cool :(

I think searching with words could work 👍. Didn't even know that also worked, thought you could only search by number...

[rnystrom]

Agree, search-by-number is obvious, might be confusing. But I'll settle for _something_ working, I guess.

[TheCodeTalker]

I think search by words would be great 👍

[dakeshi]

I think that search-by-keyword looks unnatural and unfamiliar to make autocompletion. But if we don't have another option, it would be good to use search-by-words.

I haven't seen search-by-number in both API. Although it's not a search results, we can get a list of issues in v3 Rest API (https://developer.github.com/v3/issues/). It's just a whole lists of issues.

https://api.github.com/repos/rnystrom/Freetime/issues

So, it is possible to implement autocompletion using number but it needs to filter in the client side whenever we type number. In the case of GraphQL, it doesn't have search-by-string API like REST API(GET /search/issues). What I know is just how to get issue title and number based on search-by-number(it needs an exact issue number). It would be wonderful if we can get a results using a regular expression instead of specific number.

query ($search_issue_number: Int!) {
  repository(owner:"rnystrom", name:"Freetime") {
    issue(number: $search_issue_number) {
      title
      number
    } 
  }
}

[Sherlouk]

For what it's worth regardless of whether you use GQL or V3, if you use "in:title" it does include the number if it's an exact match.

Example:

query {
  search(first: 20, query: "repo:rnystrom/GitHawk in:title 12", type: ISSUE) {
    nodes {
      ... on Issue {
        number
        title
      }
    }
  }
}

https://api.github.com/search/issues?q=repo%3Arnystrom%2FGitHawk+in%3Atitle+12&access_token=redacted

Annoyingly though GitHub doesn't support any sort of "fuzzy" search, so it will show issue 12 but not issue 123! (Likewise if you search for "autocomplet" it will return nothing, if you search for "autocomplete" it will return a bunch!)

I think that's as good as this'll be though!