Githawk: Time ago not updated on refresh

Created on 12 Jul 2017  路  9Comments  路  Source: GitHawkApp/GitHawk

See last row
img_1154

馃悰 bug

All 9 comments

Ah, that's b/c the cell isn't being reloaded. I'll have to think about this.

I think calling reloadData on reload will fix this, even tho its discouraged by IGListKit

Is there any form of reactive we could be using to update a single label every minute rather than the entire cell?

Sent with GitHawk

@Sherlouk hmm probably. We could honestly just have a 60s "forever" timer that just calls reloadData?

Hmm I just don't know how happy I am with the idea of reloading entire collection views every minute just to increase a timer! Especially with paging, there could be 100s of entries that will all be updated!

I don't see this as a particularly "uncommon" issue, be interested to see if there's something IGLK could do internally to make this a tad smoother

Actually reload data is pretty cheap since it only has to configure stuff that鈥檚 on screen. The only iffy part is rebuilding the layout, which the expensive bits (text size) are already cached. I鈥檓 gonna try this out actually and see what it鈥檚 like.

Agree tho about IGLK. I should come up with a way to do this that is framework-friendly.

Sent with GitHawk

Linking this to #218 also

Closing that one out so we're tracking stuff in one place

Think this was fixed, right @rnystrom?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

BasThomas picture BasThomas  路  3Comments

BasThomas picture BasThomas  路  3Comments

rnystrom picture rnystrom  路  3Comments

BasThomas picture BasThomas  路  3Comments

rnystrom picture rnystrom  路  3Comments