Githawk: Badge images not rendering in webview

[rnystrom]

[rnystrom]

e.g. https://github.com/Moya/Moya/issues/1163

[rnystrom]

[Sherlouk]

Just had a quick look into this, the image url is this.

Currently in the ImageCommentImageCell where we load the image we don't handle if SDWebImage throws us an error? Instead we just make the background clear and get rid of the spinner. We should probably display an error or something?

In this instance the error is: "Downloaded image has 0 pixels". This is because SDWebImage doesn't support SVG.

So basically we need an image caching library which supports GIFs, SVGs and anything else is a bonus!

Edit//
KingFisher, while doesn't natively support it, does enable you to add custom processors which people have done for SVG?

[rnystrom]

Ah, awesome. I want to add GIF support and FLAnimatedImage or w/e is already a dependency. Shouldn't be too hard.

[rnystrom]

Tracking SVGs explicitly in #268, fixed other badge sizing issues