Gitea: Issue label spacing shifting

Created on 14 Nov 2020  路  10Comments  路  Source: go-gitea/gitea

  • Gitea version (or commit ref): Gitea version 1.14.0+dev-212-g374ff6046 built with GNU Make 4.3, go1.15.5 : bindata, sqlite, sqlite_unlock_notify
  • Git version: git version 2.29.2.454.gaff20da3a2
  • Operating system: Arch Linux
  • Built from

    • [x] source

  • Run with

    • [x] systemd

  • Database:

    • [x] SQLite

  • Can you reproduce the bug at https://try.gitea.io:

    • [x] Yes

Description

While the screenshots in the subject PR look alright, after applying #13553 I have come across labels (most of them, really) being out of place and with weird spacing introduced.
Standard arc-green, no custom templates in the subject area are being used, this is how the page is shown in both ff and chromium.

Please see screenshots below.
Overlapping labels were not the best either, but this looks worse IMO.

Screenshots

anomaly 1
image
anomaly 2
image
anomaly 3
image
anomaly 4
image
anomaly 5
image

Edit: can reproduce on try.gitea.io

Most helpful comment

It actually fixes both.

All 10 comments

also, in more cases than not, this apparently affects the space after the labels as well (the big vertical gap between Labels and Milestones).
Shown in PR view, too.

anomaly 6
image

Can you try to reproduce on https://try.gitea.io/?

Can you try to reproduce on https://try.gitea.io/?

sure

Two issues here:

  1. Backend is rendering empty labels (which cause the spacing issue)
  2. Labels should be inlined

I can fix the second case.

should #13570 really close this, though, if it only fixes one of the issues you named? @silverwind

It actually fixes both.

It actually fixes both.

I first wrote it, then went on to check it..my bad.
Cheers then! 馃帀

Was this page helpful?
0 / 5 - 0 ratings

Related issues

lunny picture lunny  路  3Comments

BNolet picture BNolet  路  3Comments

kifirkin picture kifirkin  路  3Comments

ghost picture ghost  路  3Comments

Fastidious picture Fastidious  路  3Comments