Gitea: Enable Update PR base branch through API

Created on 22 May 2020 · 12Comments · Source: go-gitea/gitea

https://github.com/go-gitea/gitea/blob/88fe7b5a720365e5c8f0a347730f895263465311/routers/api/v1/repo/pull.go#L351

This API method, together with it's implementation in https://gitea.com/gitea/go-sdk should implement mutating the base branch just as available on the UI, based on adding this field into the following struct
https://github.com/go-gitea/gitea/blob/88fe7b5a720365e5c8f0a347730f895263465311/modules/structs/pull.go#L82-L93

This is required for full git-town support https://github.com/git-town/git-town/issues/1451 since git town extensively uses branch hierarchy: if the an ancestor get's merged, all it's children branches must be reassigned to the ancestor's target merge branch.

kinenhancement

Source

blaggacao

Most helpful comment

So we are waiting for https://github.com/go-gitea/gitea/pull/11666 ... :hourglass:

blaggacao on 5 Jun 2020

👍2

All 12 comments

@blaggacao If I can remember correctly UI dont support this

and why exactly do you need this?
you can Create/Update/Close/Merge a Pull via API ...

6543 on 28 May 2020

I just checked, in UI you can do this.

The use case is the following:

As colleague B, I want to complement colleague A with a sub-feature on his feature branch fbA, so I'm working on sub-feature-branch sfbB based off fbA.
Since, I'm a good dev citizen in my team, I opened a WIP branch early on with the intent to merge into fbA, so everybody could ealy track changes and advancements.
Now, colleague A's feature branch fbA was accepted into master, but my lower priority sfbB didn't make it in time and I'm still developing.
Result: my target branch is gone, therefore my PR would need to be retargeted to master.

Note: nesting is not limited to just one level, if it's a big feature in the making.

git town has first class API support in github for this workflow. In big teams, such as where git town is used, this is a not so uncommon occurrence.

@kevgo did I miss something?

I'm in the process of adding gitea support to git town to close the gap for self-hosters, like me.

blaggacao on 29 May 2020

@blaggacao sorry didnt noticed this feature exist, since it exist on UI it is relatifely easy to do so via API

6543 on 29 May 2020

@blaggacao -> #11666

6543 on 29 May 2020

Another use case is described here: developing a complex feature as a series of branches, each one implementing one change and potentially being reviewed by different people.