Gitea: [Feature] Expose name of deleted PR branches

Created on 18 Feb 2020  路  3Comments  路  Source: go-gitea/gitea

Description

When the head branch of a pull request in either state gets deleted, the pull request no longer exposes the original branch name. This is directly related to #9158, which requested tracking the ref to the tip of the deleted branch and a working commit/changes view.

I would like to suggest to also expose the name of the branch which got deleted through both UI and API instead of just showing from deleted into <target branch>. The name of the branch can usually be accessed as head.ref in the API, however the whole head property is null as soon as the branch got deleted.

Screenshots

PR with correct branch name before branch deletion

before branch deletion

PR with missing branch name after branch deletion

after branch deletion

kinenhancement

Most helpful comment

We should probably display branch name even if it is deleted just without link and marked as deleted

All 3 comments

Because that branch maybe from another repository which deleted.

We should probably display branch name even if it is deleted just without link and marked as deleted

@lafriks That's the kind of behavior I'd expect - even when the branch or repository got deleted, the PR should still expose the original branch name through UI and API.

This also follows the implementation of all other major Git platforms including GitHub and is useful for stateless bots which can determine if a PR has been previously opened by checking for a predictable branch name.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

tuxfanou picture tuxfanou  路  3Comments

jonasfranz picture jonasfranz  路  3Comments

cookiengineer picture cookiengineer  路  3Comments

ghost picture ghost  路  3Comments

kifirkin picture kifirkin  路  3Comments