Gitea: Korean localization resource looks broken for v1.11

[jeremy3825]

• Gitea version (or commit ref): v1.11
• Git version: 1.8.3.1
• Operating system: CentOS 7
• Database (use [x]):
  
  
  
  • [ ] PostgreSQL
  
  
  • [ ] MySQL
  
  
  • [ ] MSSQL
  
  
  • [x] SQLite
  
  
• Can you reproduce the bug at https://try.gitea.io:
  
  
  
  • [x] Yes (provide example URL)
  
  
  • [ ] No
  
  
  • [ ] Not relevant
  
  
• Log gist:

Description

Korean resource looks broken. I guess localization files for Korean defiled.
...

Screenshots

[sapk]

Hi, can you have a look at crowdin where the translation are managed.
If the translation are good please come back and indicate it since it may be related to font.

For more details on translations: https://github.com/go-gitea/gitea/blob/master/CONTRIBUTING.md#translation

[jeremy3825]

Thank you @sapk . I signed in crowdin to find misinterpreted string but few strings were shown. It is hard to find original English term before translation. It would be helpful if there is revision history for Korean translation.

[sapk]

Crowdin should make propositions based on previous values and translations on others projects.
If you see string with %s it means that this part will be replaced by a word and should be kept (but can be moved if needed).
If it can help you, the result of translation is stored in this file https://github.com/go-gitea/gitea/blame/master/options/locale/locale_ko-KR.ini and you can access the history of the file https://github.com/go-gitea/gitea/commits/master/options/locale/locale_ko-KR.ini
You should also be able to copy and edit this file under custom/options/locale/locale_ko-KR.ini of your setup (need a reboot for changes to apply) if you want to see the change in-situ. But all translation should be submitted via crowdin.

I can't really help you more on the process as I don't even see the letters with my setup and don't know korean ...

[jeremy3825]

Thank @sapk for your great explanations about Crowdin and language resources. I found more than 40 strings on Crowdin which have no meaning in Korean and voted them as abuses.

Also, I translated them to Korean with right meaning.

I want to review my suggestions and apply to Gitea as soon as possible.

[sapk]

Translation should have landed on master by now. We should maybe backport thoses change to v1.11 branch.

[jeremy3825]

Is migration on the way now? Still bad translations are on master.

[sapk]

They are updated each time a PR is validated. If they are not here they should come soon.
If it isn't here in few hours please indicate missing key like sign_in_with, we may have missed them on crowdin.

[jeremy3825]

I understand it takes time but translation like user_profile_and_more is not yet approved in Crowdin. I am afraid that next release would be shipped without correct translation.

[sapk]

Should be good at next PR now

[sapk]

https://github.com/go-gitea/gitea/commit/4e566df1c694e47908e59a6db163e5a98d144b83#diff-4e3fc786031f3e8c0377131eada88de2

[zeripath]

We'll need another backport of translations before 1.11rc2 I guess.

[6543]

created just a nother locales backport: #9780 :sweat_smile:

[jeremy3825]

My suggestions almost have been updated on master except ssh_port. Would you approve it?

[6543]

backport is already merged :/
I think for release candidate 2 we wont backport ...

@jeremy3825 but if you translate more stings ... it will be worth backporting for final release ...

[jeremy3825]

@6543 I know just a string is too much for backport. I hope that ssh_port would be approved quickly and see it fixed on next version. Thanks a lot.

[jeremy3825]

Correct translation for ssh_port remains unapproved on Clowdin. I'd rather close this issue with merging the last one.

[jeremy3825]

Need approval : https://crowdin.com/translate/gitea/68/enus-ko#q=ssh_port

[sapk]

Done

[jeremy3825]

@sapk I appreciate your great help for Korean users. Thanks!