Gitea: [Bug Report] Reactions API throws 500 for duplicate reaction

Created on 30 Dec 2019  路  2Comments  路  Source: go-gitea/gitea

Description

If we post a same reaction more than one time via reaction API, it will throw 500.

https://gitea.com/api/swagger#/issue/issuePostCommentReaction

POST /repos/{owner}/{repo}/issues/comments/{id}/reactions

FYI, GitHub returns 201 for created, and returns 200 for duplicated

cc @6543

Screenshots

First Time (OK)

image

Second Time (ERROR)

image

image

picture meteorlxy

Most helpful comment

Yes, a 5xx code means things do not work as expected.

BTW, I think the error details should not be exposed

picture meteorlxy on 30 Dec 2019
👍2

All 2 comments

The Api works as intended (500 is xorm error ...)

I could change this ...

6543 picture 6543 on 30 Dec 2019
❤1

Yes, a 5xx code means things do not work as expected.

BTW, I think the error details should not be exposed

meteorlxy picture meteorlxy on 30 Dec 2019
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

thehowl picture thehowl  路  3Comments
jakimfett picture jakimfett  路  3Comments
thehowl picture thehowl  路  3Comments
haytona picture haytona  路  3Comments
lunny picture lunny  路  3Comments