Gitea: [Bug/Feature Request] Markdown parse Relative Links

Created on 4 Nov 2019 · 7Comments · Source: go-gitea/gitea

Version: 1.11.0+dev-163-g86a44f6b4

Support Relative Links

for example:
![picture](img/00.png)
currently: https://<gitea-instance/<user>/img/00.png
how it should be: https://<gitea-instance/<user>/s/raw/branch/<branch>/img/00.png

we also should parse something like:
this: <img src="metadata/en-US/phoneScreenshots/02.png" width="200" />
to: <img src="https://<gitea-instance/<user>/s/raw/branch/<branch>/metadata/en-US/phoneScreenshots/02.png" width="200" />

since other github and gitlab? support this avter repo migration lot of broken links hapen ...

Source

6543

👍4

Most helpful comment

What do we make the links absolute to and how do we determine that?

There are multiple places that markdown is rendered.

We'd either need to have a set path that a markdown path is relative to (likely different for each type of markdown) or need to detect the relative path at the time of saving and absolute it. We would need to be careful about how we send the absolute path to the renderer over the API too.

It's not an insurmountable problem but it does need a bit of thought.

zeripath on 27 Jan 2020

👍2

All 7 comments

related to: #8813

6543 on 4 Nov 2019

It can be done. I wonder what are the possible ramifications (e.g. is there any security concern?); it shouldn't use the branch but the commit sha, I guess.

guillep2k on 5 Nov 2019

In Gitlab for example specifying:

[the text](/the/url)

link will be rendered with root prefix (branch, commit SHA, etc), so URL will be valid in any mode (commit, branch viewing).

Right now it doesn't do prefixing and links are unusable (will get 404 when trying to load it). See my Gitea instance running 1.10.0 as example, "This is a snip from example configuration file" phrase, it contains unusable link.

pztrn on 28 Nov 2019

👍1

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.