Gitea: Functionality that is useful for Gitea's administrative workflow

Created on 24 Oct 2019  ยท  19Comments  ยท  Source: go-gitea/gitea

As the move to gitea.com is getting closer, I was thinking about those useful features that we as maintainers will miss after we move; I mean those specifically needed for the workflow of maintaining Gitea itself.

The idea is to make a list of those features we consider the most useful, so contributors can have specific goals to help with.

As a maintainer I'm not familiar with many of the tasks involved in the administration of Gitea, so I'll start with my short list to open the discussion.

NOTE: in this list I'm collecting ideas from the comments below

  • [x] An Update branch button #9750 (#9784).
  • [ ] Select specific commits when reviewing code.
  • [x] Expand/collapse source files while reviewing code #8579 (#8924).
  • [x] The ability to expand code beyond the given context when comparing/reviewing (#8924).
  • [ ] Mark files as seen while reviewing code.
  • [x] Close/reopen issues from PR comments (#8866).
  • [x] Make changelog tool use Gitea (gitea/changelog#19).
  • [ ] Show on Pull request list page:

    • [x] Number of required approvals still remaining, or the number approvals obtained (#8762) (#9274) (#10238).

    • [x] Has the PR passed CI.

    • [ ] Is it blocked by another issue/PR.

    • [x] Does it contain conflicts (#10130).

  • [ ] Commiteable code change suggestions (beware non-utf8 encodings!); related: #9388.
  • [x] Require branches to be up to date before merging #9786 (#11012).

Extra points

  • [ ] Always display the members page for public organizations; see #7501
kinproposal

Most helpful comment

Changelog tool now supports Gitea. ๐ŸŽ‰

All 19 comments

  • [ ] A count of approvals in the PR page.

You already have that?
_This Pull Request doesn't have enough approvals yet. 1 of 2 approvals granted._
Or do you mean the list of reviewers in the right sidebar? That I think would be useful to have.

He means on the list of PRs page. In GitHub we use labels to set this but Gitea has that built in

It could be `Show approvals counts on Pull request list page"

For this one:

  • [ ] Does it produce conflicts.

I think a small client-side button to check could be used? I mean, it could show something like โ” that, when pressed, a request is sent to the server and the button is changed into โœ”๏ธ or โŒ.

It's better to add Expand Up and Expand Down button too IMO. ๐Ÿค”

It's better to add Expand Up and Expand Down button too IMO. ๐Ÿค”

Sorry, are you referring to the "does it produce conflicts" option?

Suggestions! ๐Ÿ˜ข
(Meaning the ones you can commit)

Number of required approvals still remaining, or the number approvals obtained.

I came across this issue seeing if this exact feature was possibly in progress already, or whether it was worth me having an attempt. I've never touched Go before (I'm a full-stack TypeScript dev) but love the work put into Gitea!

After some playing about for over an hour I have this:
image

The first number being the number of granted approvals, and the second the required ones. Let me know if you would be interested in a PR ๐Ÿ‘ .

@jamesorlakin sure send PR ;)

@lafriks Sure thing, I'll try to get it out tomorrow

@guillep2k
I mean the code folding/unfolding. Here is an example:
expand

@guillep2k
I mean the code folding/unfolding. Here is an example:

Oh, of course!

Changelog tool now supports Gitea. ๐ŸŽ‰

  • [ ] Does it produce conflicts. _(Much harder, probably)_

Would this just mean making use of the ConflictedFiles array on the pull model? If so, I whipped up this in a few lines by tweaking the template:
image

Would this just mean making use of the ConflictedFiles array on the pull model? If so, I whipped up this in a few lines by tweaking the template:

@jamesorlakin Care to submit a PR? ๐Ÿ˜

It seems it's easier to diaplsy files conflicted.

This is on the PRs list page not on a particular pr page.

@guillep2k you can add #11012

@guillep2k you can check Require branches to be up to date before merging by the way :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jorise7 picture jorise7  ยท  3Comments

haytona picture haytona  ยท  3Comments

kolargol picture kolargol  ยท  3Comments

flozz picture flozz  ยท  3Comments

Fastidious picture Fastidious  ยท  3Comments