Gitea: icons in file comment don't display properly

Created on 10 Sep 2019  路  3Comments  路  Source: go-gitea/gitea

Description

...
There is maybe a css error. Icons represented for editing and deleting could not show properly in file page .

Screenshots

image

kinbug

Most helpful comment

Oh, now I see it! It's a template problem indeed. .code-view is overriding octicons font settings when the comment is inside a code review; perhaps only code should be wrapped in .code-view, while headers and such should be out of it.
templates/repo/issue/view_content/comments.tmpl wraps with view-code
templates/repo/diff/section_unified.tmpl uses octicons, but font gets overriden.
I'll leave that info here in case someone wants to pick up the issue.

All 3 comments

Strange... this is what I see (as I expect):

image

Things that come to my mind:

  • Perhaps you page rendered in a character encoding different from UTF-8?
  • Perhaps your browser was unable to load some resources? Can you open the developer tools on your browser and check in the network tab if any requests ar failing?

image
You can leave your own comment and find that.

Oh, now I see it! It's a template problem indeed. .code-view is overriding octicons font settings when the comment is inside a code review; perhaps only code should be wrapped in .code-view, while headers and such should be out of it.
templates/repo/issue/view_content/comments.tmpl wraps with view-code
templates/repo/diff/section_unified.tmpl uses octicons, but font gets overriden.
I'll leave that info here in case someone wants to pick up the issue.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

lunny picture lunny  路  3Comments

Fastidious picture Fastidious  路  3Comments

ghost picture ghost  路  3Comments

jorise7 picture jorise7  路  3Comments

jonasfranz picture jonasfranz  路  3Comments