Gitea: Gitea panic

[rvillablanca]

• Gitea version (or commit ref): 1.9.0
• Git version: 2.11.0
• Operating system: Debian GNU/Linux 9.6 (stretch)
• Database (use [x]):
  
  
  
  • [ ] PostgreSQL
  
  
  • [x] MySQL
  
  
  • [ ] MSSQL
  
  
  • [ ] SQLite
  
  
• Can you reproduce the bug at https://try.gitea.io:
  
  
  
  • [ ] Yes (provide example URL)
  
  
  • [ ] No
  
  
  • [x] Not relevant
  
  
• Log gist:

https://gist.github.com/rvillablanca/16ca66169dd2c2ddf72bcf9afb5f511e

Description

Gitea just crashed. I don't know how this happened but it seems related with gravatar library.

Screenshots

No screenshots

[lunny]

Maybe @strk could give some help.

[strk]

Someone with access to the logs can tell what paniced...

[lunny]

@strk Where could we send an issue for package strk.kbt.io/projects/go/libravatar ?

[lunny]

It seems a lock is need for that map read and write.

[strk]

On Thu, Aug 15, 2019 at 06:11:07AM -0700, Lunny Xiao wrote:

@strk where we could send an issue for package strk.kbt.io/projects/go/libravatar ?

As written to that web page: to my email address,
or to the gitlab mirror.

[rvillablanca]

Is there any possibility to catch this panic ?

[lunny]

It should be an upstream library problem.

[rvillablanca]

It should be an upstream library problem.

I agree with this, it is a known library problem but it is also shutting down gitea. I think this should be logged and handled in every request by default in all http handlers. Is it allowed for an unhandled panic to crash the whole app ?

[guillep2k]

@lunny @strk I've just filed a PR in go-libravatar to address this.